Display buffer function

[FrancisMurillo]

This adds an option on how to display the prodigy and process buffer with prodigy-display-buffer-function and prodigy-process-display-buffer-function respectively. The process buffer function defaults to the main display function if not set. This also may resolve #73

[rejeep]

Hi,

A few comments:

1. Why does prodigy-switch-to-process-buffer care about prodigy-process-display-buffer-function? Seems like they should be separated to make it more clear.
2. Use backtick before and single quote after for referencing variables and functions in the doc strings.
   3 Add to the documentation of the variables that the value is an arbitrary function (or symbol) that takes a single argument, which is the buffer name or buffer object.

[rejeep]

What changed here?

[FrancisMurillo]

I don't know myself. It could be whitespace but it looks too identical.

[rejeep]

Maybe I was a bit unclear before.

Am I right when I say that you want to be able to set one variable and affect both the prodigy and the process buffer, but still be able to configure them separately?

In my head, I would prefer to have one variable for the prodigy buffer and one for the process buffer. That means if you want the same buffer function in both cases, you would have to set two variables.

How does that sound?

[FrancisMurillo]

So I separated the prodigy and process display functions to prodigy-display-buffer-function and prodigy-process-display-buffer-function, respectively. Also the process display function does not default to the prodigy display function if it is nil.

I hope I got it right.

[rejeep]

I think it looks good now, but the diff is weird, which I think is because master has changed. Can you please rebase to master? Also, I would prefer if you would squash your commits into a single one. Thanks!

[rejeep]

Still doesn't looks rebased?

[FrancisMurillo]

First time rebasing and squashing.
This is more or less how I did it

git rebase -i                             # Sort of to squash to my first commit
git fetch origin                         
git rebase origin/master          # Rebasing to master
git push --force origin display-buffer-function  #Push

Sorry for the inconvenience.

[rejeep]

I think the problem is that your master is behind mine. The easiest would be to reset your master on mine.

$ git checkout master
$ git reset --hard rejeep/master

And then rebase your branch on your master again.

You could also rebase your branch on my master directly.

[Fuco1]

The correct approach here is to customize display-buffer-alist (the end-user should do this) instead of changing the program. pop-to-buffer is perfectly fine and legal way to open a new buffer.

Many packages try to accomodate this with their own customize variables but in fact that just leads to duplication of effort and unclear semantics. You can set up rules for this with shackle easily for example.

[dmacvicar]

@Fuco1 The current way is not usable. I split windows, go to the new created one, call prodigy, and prodigy shows up in the previous one where I have the source code.

I have my straight local git repo patched to use pop-to-buffer-same-window instead of pop-to-buffer.

[DamienCassou]

I'm closing all old PRs. If you still care, please rebase your branch and reopen the PR.