Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use builtin rm to bypass any potential alias or function #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ethauvin
Copy link

@ethauvin ethauvin commented Sep 13, 2024

Otherwise, the script will fail when rm is aliased to rm -i, etc.

@yusiwen
Copy link

yusiwen commented Oct 12, 2024

I've also mapped this alias for 'rm -iv' to 'rm'. And besides, I'm using sharkdp/bat to substitute vanilla 'cat' command via an alias. These changes make 'sdk list java' command failed at exit.

Copy link

@yusiwen yusiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants