Fix find node_modules (#869)

reimagined · Nov 21, 2018 · a13bd12 · a13bd12
1 parent aaa52ea
commit a13bd12
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 15 deletions.
diff --git a/packages/core/resolve-scripts/src/get_modules_dirs.js b/packages/core/resolve-scripts/src/get_modules_dirs.js
@@ -1,25 +1,31 @@
+import fs from 'fs'
 import path from 'path'
 
 import getMonorepoNodeModules from './get_monorepo_node_modules'
 
 const getModulesDirs = ({ isAbsolutePath = false } = {}) => {
   const currentDir = process.cwd()
 
-  const currentDirNodeModules = path.resolve(currentDir, 'node_modules')
   const monorepoNodeModules = getMonorepoNodeModules()
-
-  const absoluteDirs = [
-    currentDirNodeModules,
-    path.join(
-      path.dirname(
-        require.resolve('resolve-runtime/package.json', {
-          paths: [currentDirNodeModules, ...monorepoNodeModules]
-        })
-      ),
-      'node_modules'
+  const currentDirNodeModules = path.join(currentDir, 'node_modules')
+  const resolveRuntimeNodeModules = path.join(
+    path.dirname(
+      require.resolve('resolve-runtime/package.json', {
+        paths: [currentDirNodeModules, ...monorepoNodeModules]
+      })
     ),
-    ...monorepoNodeModules
-  ]
+    'node_modules'
+  )
+
+  const absoluteDirs = []
+
+  if (fs.existsSync(currentDirNodeModules)) {
+    absoluteDirs.push(currentDirNodeModules)
+  }
+  if (fs.existsSync(resolveRuntimeNodeModules)) {
+    absoluteDirs.push(resolveRuntimeNodeModules)
+  }
+  absoluteDirs.push(...monorepoNodeModules)
 
   if (isAbsolutePath) {
     return absoluteDirs

diff --git a/packages/core/resolve-scripts/src/get_monorepo_node_modules.js b/packages/core/resolve-scripts/src/get_monorepo_node_modules.js
@@ -48,6 +48,8 @@ const getMonoreposDirs = baseDir => {
 }
 
 const getMonoreposNodeModules = () =>
-  getMonoreposDirs(process.cwd()).map(dir => path.join(dir, 'node_modules'))
+  getMonoreposDirs(process.cwd())
+    .map(dir => path.join(dir, 'node_modules'))
+    .filter(dir => fs.existsSync(dir))
 
 export default getMonoreposNodeModules
diff --git a/packages/core/resolve-scripts/src/resolve_file.js b/packages/core/resolve-scripts/src/resolve_file.js
@@ -16,7 +16,7 @@ const resolveFile = (query, fallbackQuery) => {
     require.resolve(query, {
       paths: [
         path.resolve(process.cwd(), 'node_modules'),
-        path.resolve(__dirname, '../../node_modules'),
+        path.resolve(__dirname, '../node_modules'),
         ...getMonorepoNodeModules()
       ]
     })