Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nostd-entrypoint impls #8

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ebrightfield
Copy link

@ebrightfield ebrightfield commented Sep 28, 2024

Marked as a draft because I think half of this should go in, and the other half I mostly want to show to illustrate the problem we discussed in #1.

  • Adds support for entrypoint_nostd!. See the examples for compare/contrast between the two styles of entrypoint.
  • loader.rs was easy to adapt. The module structure here should have a lib/src/loader/std.rs where all the std contents live, and then switch on features to export * from either. Waited until last minute on that, to make rebasing to master more painless. Other than that, I think the nostd loader stuff is good to go.
  • The hand-rolled approach I'm taking in this PR with CPI is probably not the best way to do it. I have an idea for some trait-based approaches which I think are better, I'll jot those down in a bit.

@Dodecahedr0x
Copy link

What's the status of this PR? Anything I can do to help?

@ebrightfield
Copy link
Author

What's the status of this PR? Anything I can do to help?

Been MIA from travel / medical stuff, but should be able to tackle it this weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants