rx.upload must include _var_data from props #4463
Merged
+40
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str-casting the dropzone arguments removed any VarData they depended on, like the state context. update test_upload to include passing a prop from a state var
Fix update chunk chaining logic; try/catch wasn't catching errors from the async inner function.
Lendemor
reviewed
Dec 2, 2024
Lendemor
approved these changes
Dec 2, 2024
masenf
added a commit
that referenced
this pull request
Dec 3, 2024
* rx.upload must include _var_data from props str-casting the dropzone arguments removed any VarData they depended on, like the state context. update test_upload to include passing a prop from a state var * Handle large payload delta from upload event handler Fix update chunk chaining logic; try/catch wasn't catching errors from the async inner function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
str-casting the dropzone arguments removed any VarData they depended on, like the state context.
update test_upload to include passing a prop from a state var.
update test_upload to include an upload handler that results in a large delta, plus a fix for handling multi-chunk deltas appropriately.