Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove input blur on Enter or Escape key press #43

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mnavarroespinosa
Copy link

Removes the blur behavior on the Datepicker input when pressing the Enter or Escape keys.

Currently, this leads to an odd user experience where the input loses focus after the Datepicker closes. It seems that this behavior is a remnant of a previous implementation that used to close the calendar upon Enter or Escape keypresses, which is no longer necessary in Reedsy fork. The Datepicker already closes by other means, so maintaining the input focus offers a better UX.

@mnavarroespinosa mnavarroespinosa requested a review from a team October 5, 2024 09:22
Copy link

@ricardoferrolho ricardoferrolho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mnavarroespinosa mnavarroespinosa merged commit 939b797 into main Oct 7, 2024
1 check passed
@mnavarroespinosa mnavarroespinosa deleted the remove-blur-on-enter branch October 7, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants