⬆ Bump eslint, typescript and jest #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidreedsy
changed the title
dawidreedsy
force-pushed
the
update-pacakges
branch
2 times, most recently
from
b6483cb to
369af4d
Compare
dawidreedsy
force-pushed
the
update-pacakges
branch
from
369af4d to
14678d3
Compare
alecgibson
reviewed
Nov 7, 2023
There was a problem hiding this comment.
You haven't bumped typescript as your PR title says
There was a problem hiding this comment.
You are right didn't even notice it, this should fix the broken build
There was a problem hiding this comment.
Changing title and description
dawidreedsy
force-pushed
the
update-pacakges
branch
from
4b36c09 to
a4ff721
Compare
|
@alecgibson |
|
@alecgibson Seems to be ok now, |
Closed
alecgibson
reviewed
Nov 8, 2023
Comment on lines
-10
to
-11
| "test": "jest --config ./test/jest.json --runInBand", | ||
| "cover": "jest --config ./test/jest.json --runInBand --coverage", |
There was a problem hiding this comment.
Did you just add --bail for testing CI failure? Can we remove please?
There was a problem hiding this comment.
Otherwise jest failes with exit code 0
There was a problem hiding this comment.
alecgibson
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to build new mongoose 8 had to bump few packages and the build worked after few changes
1.
To check for the
ObjectId, as i believe mongoose changed this.2. The validation error returns only the deepest property, but i do not think this is a problem as it still returns validation error. (Check
test/resource/create.spec.tsfor changes)3. Had to update
findfunction insrc/resource.tsas sort object like {undefined: undefined} is not being removed.4. Added
--bailoption to thenpm testscript asjestreturns exit code0otherwise