-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: examples folder refactoring #3919
WIP: examples folder refactoring #3919
Conversation
Deploy preview for redux-docs ready! Built with commit 6dd920b |
Ho-ly smoke, that's a big PR :) (I know, I know, most of it is First observation: since there may be external links that still point to those folders, can we replace the dead examples with small |
@markerikson wait wait, I did nothing else but removing the folders we said to remove and replacing the Good idea for the readme, plus i'm putting a codesandbox in the Examples.md both for the redux essentials and the fundamentals repos |
I'm fine with the one PR - just saying that |
YOLO 😄 |
Please don't switch to Yarn. We use npm for this repo. |
@timdorr good catch, I missed that. Although I think I may have used Yarn for the "Essentials" tutorial repo? At least the README file ended up saying |
I don't really care much about the tooling in other repos or even what that tooling is. It's just we should use one package manager per repo, so that tooling usage will be consistent. And so the install scripts for the examples have the right lock file format available (even though npm 7 can read yarn.lock now) |
Let me know if I can improve this pr anytime :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR we’d better split this PR into more smaller PRs.
name: 📖 New/Updated Documentation Content
about: Adding a new docs page, or updating content in an existing docs page
PR Type
Does this PR add a new page, or update an existing page?
Not yet
Checklist
yes
What docs page is being added or updated?
For Updating Existing Content
What updates should be made to the page?
Linking updated redux examples
Do these updates change any of the assumptions or target audience? If so, how do they change?
No