-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RS-550: Document support for conditional query on replication engine #138
base: main
Are you sure you want to change the base?
Conversation
atimin
commented
Dec 27, 2024
•
edited
Loading
edited
- Update HTTP API Reference
- Update SDK and CLI examles
- Fix broken links
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-138.westeurope.5.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-138.westeurope.5.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-138.westeurope.5.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-138.westeurope.5.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-138.westeurope.5.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-138.westeurope.5.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-bush-0fb136503-138.westeurope.5.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only small details to update.
I would also suggest to have the "provisioning" tab at the first position for replication tasks. As it's probably the most common?
Also found that the web console example has a formatting issue (not the first time the numbers are not aligned here; is it an issue with prettier ?)
hereduct-cli cp src-instance/example-bucket dst-instance/demo --when '{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So next release will have --when
flag and 1.13 has the --include
and --exclude
flags, right ? just to double check
@@ -42,7 +41,7 @@ async fn main() -> Result<(), ReductError> { | |||
// You can also delete all records with a specific label | |||
bucket | |||
.remove_query("rs-example") | |||
.when(json!({"&key1": {"$eq": "value1"}})) | |||
.when(condition!({"&key1": {"$eq": "value1"}})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay nice, so now you can take the condition from reduct_rs, it looks clean.
@@ -20,7 +20,7 @@ Data replication is a process of copying data from one database to another. Redu | |||
|
|||
## Concepts | |||
|
|||
The data replication in ReductStore is based on the concept of a **Replication Task**. A replication task is a configurable thread that filters and copies records from a source bucket to a target bucket. The buckets can belong to the same or different ReductStore instances. For more information on buckets, see the **[Buckets](/docs/guides/buckets.mdx)** guide. | |||
The data replication in ReductStore is based on the concept of a **Replication Task**. A replication task is a configurable thread that filters and copies records from a source bucket to a target bucket. The target bucket can belong to the same or a different ReductStore instance. For more information on buckets, see the **[Buckets](/docs/guides/buckets.mdx)** guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add a warning here to say that it's not a sync task (without sync deletions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Batch Protocol link in bolt (v1.12 et v1.13)