Feature/43 Deleted entryName field in Record class #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atimin this brunch was started from feature/42 and will rebese with main after feature/42 will merge in main branch |
|
@Rumpelshtinskiy , all good with the patch. Could you resolve the conflicts? |
Rumpelshtinskiy
force-pushed
the
feature/43
branch
from
25f9f0d to
a21bd68
Compare
Sure, but I'm still working on tests |
Rumpelshtinskiy
force-pushed
the
feature/43
branch
3 times, most recently
from
20020ed to
b2eca9a
Compare
|
@atimin done |
…hod now has an attribute entryName
Rumpelshtinskiy
force-pushed
the
feature/43
branch
from
b2eca9a to
b6d8f1b
Compare
atimin
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Refactoring
What was changed?
(Describe the changes)
Related issues
#43
Does this PR introduce a breaking change?
Yes
Other information: