Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Add Common protobuf types #879

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Backend: Add Common protobuf types #879

merged 3 commits into from
Oct 16, 2023

Conversation

bojand
Copy link
Member

@bojand bojand commented Oct 16, 2023 •
edited
Loading

Adds Common Protobuf types as included in Redpanda to Console.

Adds a utility package to schema package that embeds the protobuf files and provides utility functions to access them.

In proto and schema packages we add the common protobuf types to file maps before doing protobuf parsing.

@bojand bojand requested a review from weeco October 16, 2023 01:23
weeco
weeco approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@weeco weeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍

@bojand bojand merged commit 97227b9 into master Oct 16, 2023
5 checks passed
@bojand bojand deleted the backend/common_proto_types branch October 16, 2023 12:54
@bojand bojand mentioned this pull request Oct 16, 2023
Merged
@bojand bojand restored the backend/common_proto_types branch April 12, 2024 00:25
@bojand bojand deleted the backend/common_proto_types branch April 12, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeco weeco weeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bojand @weeco