frontend: Add vitest #1538
Merged
frontend: Add vitest #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinskibeniamin
force-pushed
the
console-frontend-vitest
branch
from
15b9098 to
cf93aad
Compare
malinskibeniamin
force-pushed
the
console-frontend-vitest
branch
5 times, most recently
from
e43c799 to
e6646ea
Compare
jvorcak
approved these changes
Nov 29, 2024
weeco
approved these changes
Nov 29, 2024
malinskibeniamin
force-pushed
the
console-frontend-vitest
branch
from
0884336 to
76b9018
Compare
malinskibeniamin
force-pushed
the
console-frontend-vitest
branch
from
76b9018 to
a39feb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No logic change. Just test setup using
vitest.Example with passing pipeline can be found here.
There were very few tests written, some of which didn't make sense anymore or got too outdated for me to bring them back.
It will be important to start using the later versions of connect including connect query to achieve parity with Cloud UIs, so that testing can be done in the same way through creating a connect transport layer and mocking rpc commands. That way it will be easier to switch between the 2 projects more seamlessly.
