Feature: Debug Bundle #1493
Feature: Debug Bundle #1493
Conversation
proto: broker_ids -> broker_id
Backend/debug bundle
proto: remove required from label selector param
…alhy report structure.
|
The latest Buf updates on your PR. Results from workflow Buf CI / push-module (pull_request).
|
…le into feature/debug-bundle
| - buf.build/envoyproxy/protoc-gen-validate:dfcdc5ea103dda467963fb7079e4df28debcfd28 | ||
| - buf.build/grpc-ecosystem/grpc-gateway:a1ecdc58eccd49aa8bea2a7a9022dc27 | ||
| - buf.build/googleapis/googleapis | ||
| - buf.build/bufbuild/protovalidate | ||
| - buf.build/redpandadata/common |
There was a problem hiding this comment.
Why can we remove these dependencies?
There was a problem hiding this comment.
they were not being used in any of the protos
| // leaderless partitions. example values: | ||
| map<string, PartitionIDList> leaderless_partitions = 8; |
There was a problem hiding this comment.
I assume the string refers to the topic name. I'm wondering whether an own type has better semantics:
message TopicPartitions {
string topic_name = 1;
repeated int32 partition_ids = 2;
}There was a problem hiding this comment.
There was a problem hiding this comment.
Fine for me to keep then, but for a public API eventually - I think we should change it to a separate type
There was a problem hiding this comment.
The current structure is convenient for the frontend, but what @weeco suggest is also doable. If we can get consistent with the public API later, I'm ok with changing the FE for this purpose. It's up to you.
There was a problem hiding this comment.
I have changed the type to represent the suggestion.
| bool is_healthy = 1; | ||
|
|
||
| repeated UnhealthyReason unhealthy_reasons = 2; | ||
| int32 controller_id = 3; |
There was a problem hiding this comment.
I think in some scenarios it's possible to have no controller in a cluster. Wondering whether we want to make it an optional or report a negative number. Maybe worth to check what franz-go does and if we choose to report a negative number in that case we should document it here.
There was a problem hiding this comment.
Admin API return -1 if leader is not elected. I changed the property to be optional.
fix names in cluster haelth Co-authored-by: Martin Schneppenheim <[email protected]>
fix under_replicated_partitions_count name Co-authored-by: Martin Schneppenheim <[email protected]>
use leaderless_partitions_count Co-authored-by: Martin Schneppenheim <[email protected]>
…ta/console into feature/debug-bundle
| @@ -83,43 +125,89 @@ message DebugBundleStatus { | |||
| // Path in API to get the file. | |||
| string filename = 5; | |||
|
|
|||
| // Size of the debug bundle zip file. | |||
| int64 size = 6; | |||
There was a problem hiding this comment.
You already used the _bytes suffix above:
controller_logs_size_limit_bytes
I think that's missing here. AIP-141 says:
Quantities with a clear unit of measurement (such as bytes, miles, and so on) must include the unit of measurement as the suffix.
Adds the proto types and service definitions for debug bundle feature.
Adds frontend implementation.