backend: list message concurrent stream send fix #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeco
reviewed
Feb 5, 2024
| timeout = 31 * time.Minute | ||
| } | ||
|
|
||
| ctx, cancel := context.WithTimeoutCause(ctx, timeout, errors.New("list fetch timeout")) |
There was a problem hiding this comment.
Very good to add the reason there 👍
weeco
reviewed
Feb 5, 2024
Comment on lines
+105
to
+107
| if message == nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
Wondering why this is necessary? When would we send nil here?
There was a problem hiding this comment.
it was just a guard I added as I was debugging. we really shouldn't but might be a good idea.
weeco
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple goroutines may perform writes (stream
Send()s) to the stream via stream reporter. In stream reporter ensure these are guarded using a mutex.Minor frontend cleanup to only have a single Console service client.
Fixes #1073.