Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some checks to acommodate for clients where ICMP is disabled by firewall #287

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gojeaqui
Copy link
Contributor

When testing for connectivity Use NetCat instead of ping to test BMC and NTP connection, since some firewalls might block ICMP.
On the ohter hand the "bmc_ip" variable should not be required for vendor: PXE

@gojeaqui gojeaqui requested a review from a team as a code owner November 10, 2023 18:15
@nocturnalastro
Copy link
Collaborator

Theres another ping for testing network connectiveity after appling the network config. Could you update this one as well.
https://github.com/redhat-partner-solutions/crucible/blob/main/roles/apply_nmstate/tasks/main.yml#L40

@gojeaqui
Copy link
Contributor Author

Theres another ping for testing network connectiveity after appling the network config. Could you update this one as well. https://github.com/redhat-partner-solutions/crucible/blob/main/roles/apply_nmstate/tasks/main.yml#L40

@nocturnalastro in this case it is OK to have a ping because that IP address does not correspond to any type of service so I wouldn't know to which port NetCat should probe. Besides it is configurable to any host the user chooses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants