OPCT-257: cleanup for openshift-tests-plugin refactor on v0.5.0

[mtulio]

Clean up unused functions left behind in the openshift-tests plugin refactor on v0.5.0 (#57)

[mtulio]

Local tests the plugin collector finished correctly:

time="2024-08-13T16:47:19Z" level=info msg="[DEBUG] POST http://127.0.0.1:8099/progress"
2024-08-13T16:47:19+00:00 | [collector] | collector:173>  [executor][PluginID#99] Packing all results...
4.0K ./artifacts_e2e-metadata-openshift-cluster-upgrade.tar.gz
 12K ./artifacts_e2e-metadata-openshift-conformance-validated.tar.gz
 12K ./artifacts_e2e-metadata-openshift-kube-conformance.tar.gz
4.0K ./artifacts_e2e-metadata-openshift-tests-replay.tar.gz
   0 ./artifacts_e2e-tests_openshift-cluster-upgrade.txt
4.0K ./artifacts_e2e-tests_openshift-conformance-validated.txt
4.0K ./artifacts_e2e-tests_openshift-kube-conformance.txt
4.0K ./artifacts_e2e-tests_openshift-tests-replay.txt
324K ./artifacts_must-gather-metrics.tar.xz
 13M ./artifacts_must-gather.tar.xz
2.8M ./artifacts_must-gather_camgi.html
 12K ./artifacts_performance_etcdfio_controlplane-0.txt
 12K ./artifacts_performance_etcdfio_controlplane-1.txt
 12K ./artifacts_performance_etcdfio_controlplane-2.txt
 12K ./artifacts_performance_etcdfio_worker-0.txt
 12K ./artifacts_performance_etcdfio_worker-1.txt
time="2024-08-13T16:47:19Z" level=info msg="[DEBUG] POST http://127.0.0.1:8099/progress"
/plugin
time="2024-08-13T16:47:19Z" level=info msg="[DEBUG] POST http://127.0.0.1:8099/progress"
2024-08-13T16:47:19+00:00 | [collector] | entrypoint-collector:75>  Plugin finished.
2024-08-13T16:47:19+00:00 | [collector] | entrypoint-collector:22>  Saving results triggered. Slowing down...
/tmp/sonobuoy/results /plugin
2024-08-13T16:47:24+00:00 | [collector] | entrypoint-collector:27>  Sending sonobuoy worker the result file path
time="2024-08-13T16:47:24Z" level=info msg="[DEBUG] POST http://127.0.0.1:8099/progress"
2024-08-13T16:47:24+00:00 | [collector] | entrypoint-collector:30>  Results saved at /tmp/sonobuoy/results/done=[/tmp/sonobuoy/results/raw-results.tar.gz]
/plugin

[mtulio]

PTAL?
/assign @rvanderp3

[mtulio]

Local[1] and GHA are passing, moving on to unblock periodic job PR openshift/release#54722

[1] local tests on archive opct-devel_v0.5_aws-aws-opct_202408131745_9dd0adf1-df49-44fd-ae32-9c2ace0946c9.tar.gz indexed as 4.17_AWS_20240813215230

┌───────────────────────────────────────────┐
│ 05-openshift-cluster-upgrade: ✅          │
├───────────────────────────┬───────────────┤
│ Total tests               │ 1             │
│ Passed                    │ 0             │
│ Failed                    │ 0             │
│ Timeout                   │ 0             │
│ Skipped                   │ 1             │
│ Result Job                │ passed        │
└───────────────────────────┴───────────────┘
┌───────────────────────────────────────────┐
│ 10-openshift-kube-conformance: ✅         │
├───────────────────────────┬───────────────┤
│ Total tests               │ 399           │
│ Passed                    │ 399           │
│ Failed                    │ 0             │
│ Timeout                   │ 0             │
│ Skipped                   │ 0             │
│ Filter Failed Suite       │ 0 (0.00%)     │
│ Filter Failed KF          │ 0 (0.00%)     │
│ Filter Replay             │ 0 (0.00%)     │
│ Filter Failed Baseline    │ 0 (0.00%)     │
│ Filter Failed Priority    │ 0 (0.00%)     │
│ Filter Failed API         │ 0 (0.00%)     │
│ Failures (Priotity)       │ 0 (0.00%)     │
│ Result - Job              │ passed        │
│ Result - Processed        │ passed        │
└───────────────────────────┴───────────────┘
┌───────────────────────────────────────────┐
│ 20-openshift-conformance-validated: ✅    │
├───────────────────────────┬───────────────┤
│ Total tests               │ 3783          │
│ Passed                    │ 1570          │
│ Failed                    │ 20            │
│ Timeout                   │ 0             │
│ Skipped                   │ 2193          │
│ Filter Failed Suite       │ 18 (0.48%)    │
│ Filter Failed KF          │ 18 (0.48%)    │
│ Filter Replay             │ 16 (0.42%)    │
│ Filter Failed Baseline    │ 16 (0.42%)    │
│ Filter Failed Priority    │ 16 (0.42%)    │
│ Filter Failed API         │ 0 (0.00%)     │
│ Failures (Priotity)       │ 0 (0.00%)     │
│ Result - Job              │ failed        │
│ Result - Processed        │ passed        │
└───────────────────────────┴───────────────┘
┌───────────────────────────────────────────┐
│ 80-openshift-tests-replay: ⚠              │
├───────────────────────────┬───────────────┤
│ Total tests               │ 19            │
│ Passed                    │ 3             │
│ Failed                    │ 16            │
│ Timeout                   │ 0             │
│ Skipped                   │ 0             │
│ Filter Failed Suite       │ 16 (84.21%)   │
│ Filter Failed KF          │ 16 (84.21%)   │
│ Filter Replay             │ 0 (0.00%)     │
│ Filter Failed Baseline    │ 0 (0.00%)     │
│ Filter Failed Priority    │ 0 (0.00%)     │
│ Filter Failed API         │ 0 (0.00%)     │
│ Failures (Priotity)       │ 16 (84.21%)   │
│ Result - Job              │ failed        │
│ Result - Processed        │ failed        │
└───────────────────────────┴───────────────┘
┌───────────────────────────────────────────┐
│ 99-openshift-artifacts-collector: ✅      │
├───────────────────────────┬───────────────┤
│ Total tests               │ 16            │
│ Passed                    │ 16            │
│ Failed                    │ 0             │
│ Timeout                   │ 0             │
│ Skipped                   │ 0             │
│ Result Job                │ passed        │
└───────────────────────────┴───────────────┘

┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Validation checks / Results                                                                                                                                      │
├───────────┬───┬────────┬────────────────────────────────────────────────────────────────────────────────────────┬──────────────────────────────┬─────────────────┤
│     ID    │ # │ RESULT │                                       CHECK NAME                                       │            TARGET            │     CURRENT     │
├───────────┼───┼────────┼────────────────────────────────────────────────────────────────────────────────────────┼──────────────────────────────┼─────────────────┤
│ OPCT-010  │ ⚠ │  warn  │ The cluster logs should generate fewer error reports in the logs                       │ W:<=30k,F:>100k              │ 99363           │
├───────────┼───┼────────┼────────────────────────────────────────────────────────────────────────────────────────┼──────────────────────────────┼─────────────────┤
│ OPCT-020  │ ✔ │  pass  │ All nodes must be healthy                                                              │ 100%                         │ 100.000%        │
....
───────────┼───┼────────┼────────────────────────────────────────────────────────────────────────────────────────┼──────────────────────────────┼─────────────────┤
│           │   │        │    TOTAL: 23, FAILED: 0 (0.00%), WARN: 1 (4.35%), PASS: 22 (95.65%), SKIP: 0 (0.00%)   │                              │                 │
└───────────┴───┴────────┴────────────────────────────────────────────────────────────────────────────────────────┴──────────────────────────────┴─────────────────┘