[RELEASE-1117] Add retry when requesting RADAS signature #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run the signing pipeline in Konflux a lot and users report that oftentimes one or a few of the requests fail. In theory some retry should work on the Python library level, but it doesn't really seem to work. So this should help. See Jira for more details. Signed-off-by: Martin Malina <[email protected]>
|
@Allda the Build and push image test failed. Can you check? It failed on docker auth. I know that normally PR events don't have access to secrets, so I'm not sure how this is supposed to work. Anything I need to do? |
Allda
approved these changes
Sep 26, 2024
|
@mmalina We haven't figured out how to support actions from an outside collaborator. Since this is not affecting a build part I'll merge it and build and the test will be executed right after that. |
|
@Allda cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run the signing pipeline in Konflux a lot and users report that oftentimes one or a few of the requests fail.
In theory some retry should work on the Python library level, but it doesn't really seem to work. So this should help. See Jira for more details.
BTW, how can I test this? I copied the whole script block to a separate file and ran it with various mock functions to simulate different behavior and it worked for me. But it would be nice if we could test it as part of a Tekton pipeline.