-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding call to pyxis for non EOL catalogs and updating imagestream logic #160
Merged
acornett21
merged 1 commit into
redhat-openshift-ecosystem:main
from
acornett21:implement_pyxis_catalog_lookup
Aug 26, 2024
Merged
adding call to pyxis for non EOL catalogs and updating imagestream logic #160
acornett21
merged 1 commit into
redhat-openshift-ecosystem:main
from
acornett21:implement_pyxis_catalog_lookup
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acornett21
force-pushed
the
implement_pyxis_catalog_lookup
branch
from
August 12, 2024 20:38
af0e332
to
152ad19
Compare
skattoju
reviewed
Aug 13, 2024
acornett21
force-pushed
the
implement_pyxis_catalog_lookup
branch
from
August 13, 2024 15:56
152ad19
to
ecf820f
Compare
komish
reviewed
Aug 16, 2024
komish
reviewed
Aug 16, 2024
komish
reviewed
Aug 16, 2024
acornett21
force-pushed
the
implement_pyxis_catalog_lookup
branch
from
August 19, 2024 20:47
ecf820f
to
d124aba
Compare
bcrochet
requested changes
Aug 21, 2024
Signed-off-by: Adam D. Cornett <[email protected]>
acornett21
force-pushed
the
implement_pyxis_catalog_lookup
branch
from
August 21, 2024 20:45
d124aba
to
f42aa16
Compare
bcrochet
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
komish
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The old logic we have in place was trying to mirror
all
of the tags within a givennamespace/image
, and since there are about ~4k tags at this point, our logic would timeout and not create an ImageStream. This could cause us to be stuck on these sub-reconcilers, until a user manually added the imagestreams with the tags that they cared about.Implementation
For the implementation, a graphql client for pyxis was added and a query that looks for non End Of Life catalogs. For the implementation of the query we can look for OCP versions where
eol equals null
.Sample GraphQL Query
Testing
This was tested in a cluster both as a catalog/bundle and also running locally in debug mode.
As you can see we only get the tags for catalogs which are not EOL.