Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify markdown formatting and file name #425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modify markdown formatting and file name #425

wants to merge 1 commit into from

Conversation

F1uxCapacitor
Copy link

Changed file name to a more standard file extension for markdown README files
Edited section header formatting
Created code blocks

Changed file name to a more standard file extension for markdown README files
Edited section header formatting
Created code blocks
@tyll tyll mentioned this pull request Nov 12, 2019
Copy link

@tyll tyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your changes. They look mostly good for me. There are small issues with the bash code.

Unfortunately I cannot merge code here but I hope someone will, soon.


Ensure to change the element to your desired root password.

Next, use the imagefactory command and specify the template to use and for which
clouds to build an image. The above template example was saved to a file name f12_64.tdl.

```bash
$ sudo imagefactory --template f12_64.tdl --target ec2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not valid bash code with the prompt $ included, IMHO it would be nicer to remove the prompt. Everyone who understands what it should mean can probably also deduct this from sudo being used.


Once the image has been built, use the imagefactory command again, this time to
push the image into the cloud.

```bash
$ sudo imagefactory --provider ec2-us-west-1 --credentials ec2_credentials.xml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue with the prompt as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants