Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the go-gpt3 package #97

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Use the go-gpt3 package #97

merged 2 commits into from
Aug 1, 2022

Conversation

RobotSail
Copy link
Collaborator

This PR aims to close #87 by replacing our openai package with the upstream go-gpt3 package.
This way, other people besides us can contribute to and benefit from the go-gpt3 repository, and our pull-requests there will also benefit other users.
We also eliminate some amount of technical debt with this transition, since there is now less to maintain within our own repository.

This change also adds a minor refactor which moves config-related stuff into a separate package underneath pkg/cmd.

@RobotSail RobotSail added this to the TBD milestone Aug 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #97 (013791c) into main (2dd6622) will decrease coverage by 6.86%.
The diff coverage is 65.78%.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   73.74%   66.88%   -6.87%     
==========================================
  Files           7        7              
  Lines         598      625      +27     
==========================================
- Hits          441      418      -23     
- Misses        135      188      +53     
+ Partials       22       19       -3     
Impacted Files Coverage Δ
pkg/cmd/config/config.go 0.00% <ø> (ø)
pkg/filemap/filemap.go 53.88% <0.00%> (-5.80%) ⬇️
pkg/cmd/utils.go 78.76% <72.72%> (-0.61%) ⬇️
pkg/cmd/edit.go 83.01% <100.00%> (+3.47%) ⬆️
pkg/cmd/generate.go 86.25% <100.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd6622...013791c. Read the comment docs.

@RobotSail
Copy link
Collaborator Author

We'll probably want PR #73 to merge before this one, and we can pull out all of the refactors that happened with moving config into a sub-package.

Signed-off-by: Oleg <[email protected]>
@guymguym guymguym merged commit 0006b62 into redhat-et:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially use go-gpt3 as a client for OpenAI
3 participants