Roles import optimatization by modifying the export + 2 minor bugs #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2024 12:51
przemkalit
requested review from
silvinux,
ivarmu and
adonisgarciac
as code owners
added 2 commits
July 31, 2024 13:15
przemkalit
changed the title
|
thoughts? |
|
if you update the branch I will merge this |
przemkalit
added a commit
to przemkalit/controller_configuration
that referenced
this pull request
Nov 22, 2024
…edhat-cop#884) * misc: roles export optimization, fix approval role for users, fix admin roles * fix: typo * fix: add missing changelog * fix: remove new lines * fix: add missing new line --------- Co-authored-by: Przemyslaw Kalitowski <[email protected]> Co-authored-by: Ivan Aragonés Muniesa <[email protected]> Co-authored-by: David Danielsson <[email protected]>
przemkalit
added a commit
to przemkalit/controller_configuration
that referenced
this pull request
Nov 22, 2024
…edhat-cop#884) * misc: roles export optimization, fix approval role for users, fix admin roles * fix: typo * fix: add missing changelog * fix: remove new lines * fix: add missing new line --------- Co-authored-by: Przemyslaw Kalitowski <[email protected]> Co-authored-by: Ivan Aragonés Muniesa <[email protected]> Co-authored-by: David Danielsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the way roles are exported in the current version of the collection. Previously, every single permission role was added as a separate entry. I've modified it so that objects related to a role are matched with that role. As a result, the entry for a role is now presented as follows.
Thanks to that, the number of requests sent to the API is decreasing.
Let me know what you think. If you have any suggestions, I would be grateful.
Additionally, there are two changes: one related to the approval role, which I fixed for teams but not for users, and another issue with the
job template admin,project admin, and similar roles. These roles are exported without underscores, which prevents them from being imported.How should this be tested?
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc
#876