Fix approval role permission name in object diff.

redhat-cop · Aug 6, 2024 · 6a3c083 · 6a3c083
1 parent a288e75
commit 6a3c083
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/changelogs/fragments/aapproval_role_name_object_diff.yml b/changelogs/fragments/aapproval_role_name_object_diff.yml
@@ -0,0 +1,4 @@
+---
+bugfixes:
+  - Fix "approval" role permission name in object diff.
+...
diff --git a/plugins/lookup/controller_object_diff.py b/plugins/lookup/controller_object_diff.py
@@ -231,7 +231,11 @@ def run(self, terms, variables=None, **kwargs):
                     item.update({"organizations": [item[item["resource_type"]]]})
                 if item["resource_type"] == "instance_group":
                     item.update({"instance_groups": [item[item["resource_type"]]]})
-                item.update({"role": item["name"].lower().replace(" ", "_").replace("ad_hoc", "adhoc")})
+                item.update({"role": item["name"].lower()
+                                        .replace(" ", "_")
+                                        .replace("ad_hoc", "adhoc")
+                                        .replace("approve", "approval")
+                                        })
                 # Remove the extra fields
                 item.pop("users")
                 item.pop("teams")