Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing labels property for ResourceClaim #2265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing labels property for ResourceClaim #2265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions notifier/operator/resource_claim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ def annotations(self):
def catalog_item_name(self):
return self.definition.get('status', {}).get('summary', {}).get(
'catalog_item_name',
self.definition['metadata'].get('labels', {}).get('babylon.gpte.redhat.com/catalogItemName')
self.labels.get('babylon.gpte.redhat.com/catalogItemName')
)

@property
def catalog_item_namespace(self):
return self.definition.get('status', {}).get('summary', {}).get(
'catalog_item_namespace',
self.definition['metadata'].get('labels', {}).get('babylon.gpte.redhat.com/catalogItemNamespace')
self.labels.get('babylon.gpte.redhat.com/catalogItemNamespace')
)

@property
Expand Down Expand Up @@ -85,6 +85,10 @@ def is_stopped(self):
return False
return stopped

@property
def labels(self):
return self.definition['metadata'].get('labels', {})

@property
def last_started_timestamp(self):
if not 'status' in self.definition \
Expand Down