Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODS-1932 - Verify user can edit a S3 data connection #846

Merged
merged 3 commits into from
Jul 6, 2023
Merged

ODS-1932 - Verify user can edit a S3 data connection #846

merged 3 commits into from
Jul 6, 2023

Conversation

diegolovison
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 5, 2023
View reviewed changes
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
... ${DC_SECTION_XP}//tr[td[@data-label="Name"]/*/div[text()="${name}"]]/td[@data-label="Connected workbenches"]/ul/li[text()="${workbench_title}"]
END
END

Data Connection Should Not Be Listed
[Documentation] Checks a Data Connection is not listed in DS Project details page
[Arguments] ${name}
Run keyword And Continue On Failure Wait Until Page Does Not Contain Element
Run keyword And Continue On Failure Wait Until Page Does Not Contain Element

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention

Keyword name 'Run keyword And Continue On Failure' does not follow case convention
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
@@ -66,25 +56,25 @@
Data Connection Should Be Listed
[Documentation] Checks a Data Connection is listed in DS Project details page
[Arguments] ${name} ${type} ${connected_workbench}
Run keyword And Continue On Failure Page Should Contain Element
Run keyword And Continue On Failure Page Should Contain Element

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention

Keyword name 'Run keyword And Continue On Failure' does not follow case convention
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
... aws_bucket_name=${aws_bucket_name}
Wait Until Project Is Open project_title=${project_title}

Edit S3 Data Connection

Check warning

Code scanning / Robocop

Keyword '{{ keyword_name }}' has too many arguments ({{ arguments_count }}/{{ max_allowed_count }})

Keyword 'Edit S3 Data Connection' has too many arguments (9/5)
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource Fixed Show fixed Hide fixed
@diegolovison diegolovison force-pushed the edit_data_connection branch from 2d17fe8 to 461b25c Compare July 6, 2023 13:21
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 6, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

bdattoma
bdattoma reviewed Jul 6, 2023
View reviewed changes
...tests/Tests/400__ods_dashboard/415__ods_dashboard_projects/415__ods_dashboard_projects.robot
... aws_access_key=${DC_S3_AWS_SECRET_ACCESS_KEY}
... aws_secret_access=${DC_S3_AWS_SECRET_ACCESS_KEY}
... aws_s3_endpoint=${DC_S3_ENDPOINT} aws_region=${DC_S3_REGION}
Edit S3 Data Connection project_title=${PRJ_TITLE} dc_name=${DC_S3_NAME}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you edit the name too?

bdattoma
bdattoma previously approved these changes Jul 6, 2023
View reviewed changes
@bdattoma bdattoma added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Jul 6, 2023
@jgarciao jgarciao merged commit 908c47e into red-hat-data-services:master Jul 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdattoma bdattoma bdattoma approved these changes

@jgarciao jgarciao jgarciao approved these changes

Assignees

@diegolovison diegolovison

Labels
needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegolovison @jgarciao @bdattoma