Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelServer Dashboard - fix UI issues #1927

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

ModelServer Dashboard - fix UI issues #1927

wants to merge 15 commits into from

Conversation

rnetser
Copy link
Contributor

@rnetser rnetser commented Oct 14, 2024

  • Replicas
  • Token
  • Model server runtime

rnetser added 13 commits October 13, 2024 16:54
@rnetser
update replicas
2954f1a 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
Merge branch 'master' of https://github.com/red-hat-data-services/ods-ci
4d02ad9 
 into fix-project-drop-down

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
update replicas
02fefdf 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
fix ui token
fa88657 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
Merge branch 'master' of https://github.com/red-hat-data-services/ods-ci
f8008f0 
 into fix-project-drop-down

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
fix sr dropdown
b351683 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
fix sr dropdown
ac9ab57 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
fix delete all projects
438f124 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
Merge branch 'master' of https://github.com/red-hat-data-services/ods-ci
91696c0 
 into fix-project-drop-down

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
fix sr dropdown
c2e21e7 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
sfix replicas modelmesh
8eea7d4 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
Merge branch 'master' of https://github.com/red-hat-data-services/ods-ci
c8cb049 
 into fix-project-drop-down

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
remove spaces
394ddc0 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 14, 2024
View reviewed changes
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource
${REPLICAS_COUNT_XP}= xpath://section[@class='pf-v5-c-form__section']//span[@class='pf-v5-c-form-control']/input
${PROJECT_SELECTOR_XP}= xpath://main[contains(@id, 'dashboard-page-main')]//*[@data-testid="project-selector-dropdown"]
${REPLICAS_COUNT_XP}= css=[aria-label="model server replicas number input"]
${PROJECT_SELECTOR_XP}= xpath://main[contains(@id, 'dashboard-page-main')]//*[@data-testid="project-selector-toggle"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (121/120)
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource
@@ -228,7 +228,7 @@
[Documentation] Gets the (Single Model) Token of an specific Service Account
[Arguments] ${service_account_name}
${token}= Get Element Attribute
... xpath://div[text()='${service_account_name}']/parent::td[@data-label='Token Name']/following-sibling::td[@data-label='Token Secret']//input value
... xpath://div[text()='${service_account_name}']/../../parent::td[@data-label='Token Name']/following-sibling::td[@data-label="Token Secret"]//input value

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (172/120)
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource
@@ -228,7 +228,7 @@
[Documentation] Gets the (Single Model) Token of an specific Service Account
[Arguments] ${service_account_name}
${token}= Get Element Attribute
... xpath://div[text()='${service_account_name}']/parent::td[@data-label='Token Name']/following-sibling::td[@data-label='Token Secret']//input value
... xpath://div[text()='${service_account_name}']/../../parent::td[@data-label='Token Name']/following-sibling::td[@data-label="Token Secret"]//input value

Check warning

Code scanning / Robocop

Continuation marker should be aligned with starting row Warning test

Continuation marker should be aligned with starting row
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
545 0 0 545 100

@jstourac jstourac mentioned this pull request Oct 14, 2024
Merged
@rnetser
fix success
4adf690 
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@rnetser
Merge branch 'master' of https://github.com/red-hat-data-services/ods-ci
2b63cd3 
 into fix-project-drop-down

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 14, 2024
View reviewed changes
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHModelServing.resource
... //div[.="${model_name} "]${MS_TABLE_STATUS}${MS_TABLE_STATUS_SUCCESS} timeout=2m
Page Should Not Contain Element //div[.="${model_name} "]${MS_TABLE_STATUS}${MS_TABLE_STATUS_FAILURE}
... //a[text()='test-model']/ancestor::td${MS_TABLE_STATUS}${MS_TABLE_STATUS_SUCCESS} timeout=2m
Page Should Not Contain Element //a[text()='test-model']/ancestor::td${MS_TABLE_STATUS}${MS_TABLE_STATUS_FAILURE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (124/120)
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHModelServing.resource
... //div[.="${model_name} "]${MS_TABLE_STATUS}${MS_TABLE_STATUS_FAILURE} timeout=2m
Page Should Not Contain Element //div[.="${model_name} "]${MS_TABLE_STATUS}${MS_TABLE_STATUS_SUCCESS}
... //a[text()='test-model']/ancestor::td${MS_TABLE_STATUS}${MS_TABLE_STATUS_FAILURE} timeout=2m
Page Should Not Contain Element //a[text()='test-model']/ancestor::td${MS_TABLE_STATUS}${MS_TABLE_STATUS_SUCCESS}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (124/120)
manosnoam
manosnoam reviewed Oct 27, 2024
View reviewed changes
Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you rebase and add a screenshot of the relevant tests' result ?

@rnetser
Copy link
Contributor Author

rnetser commented Nov 13, 2024

changes were done in other PRs. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manosnoam manosnoam manosnoam left review comments

@lugi0 lugi0 Awaiting requested review from lugi0

@mwaykole mwaykole Awaiting requested review from mwaykole

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnetser @manosnoam