Skip to content

Update Konflux references #325

Update Konflux references

Update Konflux references #325

Triggered via push November 20, 2024 12:02
Status Failure
Total duration 32s
Artifacts
Matrix: golangci-lint
Matrix: govulncheck
Fit to window
Zoom out
Zoom in

Annotations

20 errors
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/e2e/notebook_creation_test.go#L142
SA4009: argument err is overwritten before first use (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper_test.go#L25
SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper_test.go#L61
SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper_test.go#L80
SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L325
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.KernelStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L362
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.TerminalStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L137
S1033: unnecessary guard around call to delete (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L266
SA5011: possible nil pointer dereference (staticcheck)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L267
SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L359
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.KernelStatus is defined as zero (gosimple)