More errors #90
Open
More errors #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackdotink
reviewed
Jun 11, 2024
This reverts commit 7e89158.
jackdotink
requested changes
Jul 7, 2024
zapc/src/hir_builder/decl.rs
Outdated
Comment on lines
207
to
234
| if word == "server" || word == "client" { | ||
| self.report(Report::ExpectedValueWrongType { | ||
| value_span: words.first().unwrap().span().merge(words.last().unwrap().span()), | ||
| expected_values: "\"client\" or \"server\"".to_string(), | ||
| found_type: "path".to_string(), | ||
| help: Some("add quotes to turn the path into a string".to_string()), | ||
| }); | ||
|
|
||
| return HirEventSource::Server; | ||
| } else if word == "Server" || word == "client" { | ||
| self.report(Report::ExpectedValueWrongType { | ||
| value_span: words.first().unwrap().span().merge(words.last().unwrap().span()), | ||
| expected_values: "\"client\" or \"server\"".to_string(), | ||
| found_type: "path".to_string(), | ||
| help: Some("lowercase the word and add quotes to turn the path into a string".to_string()), | ||
| }); | ||
|
|
||
| return HirEventSource::Server; | ||
| } | ||
| } else { | ||
| // todo: report error | ||
| } | ||
|
|
||
| self.report(Report::ExpectedValueWrongType { | ||
| value_span: words.first().unwrap().span().merge(words.last().unwrap().span()), | ||
| expected_values: "\"client\" or \"server\"".to_string(), | ||
| found_type: "path".to_string(), | ||
| help: None, | ||
| }); | ||
|
|
There was a problem hiding this comment.
we will almost certainly not reuse ExpectedValueWrongType, so I think it would be a better idea to create a more specific report variant for this case.
zapc/src/hir_builder/ty.rs
Outdated
| if generics.len() > 1 { | ||
| // todo: report extra generics | ||
| self.report(Report::IncorrectGenericCount { | ||
| type_span: segment.span(), |
There was a problem hiding this comment.
this wouldn't be the span of the entire type
imagine the type buffer<a, b> - this would only be the span for buffer when you really want it to be the span for the whole type
|
CI was failing because of Rustfmt. It wasn't a file I touched but I formatted it anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.