feat: Add version command #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkaplan
force-pushed
the
jdkaplan-version-cmd
branch
2 times, most recently
from
d300ee4
to
ccd2502
Compare
This reads the Google App Engine version from the environment and returns it in response to a new `version` command. Since we don't currently name our GAE versions, we get timestamps (like '20240904t202224'). That's still good enough to show the difference between two builds.
jdkaplan
force-pushed
the
jdkaplan-version-cmd
branch
from
4841dad
to
e419438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads the Google App Engine version from the environment and returns it in response to a new
versioncommand.Ideally, we'd be able to get the current commit hash, but I haven't figured out a nice way to make that work through Cloud Build + App Engine. I suspect the answer is to start pushing our own Docker images, and that's something I don't want to do yet.
Since we don't currently name our GAE versions, we get timestamps (like
20240904t202224). That's still good enough to show the difference between two builds.Test Plan
dev!