Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Skip private dataProvider method on RemoveUnusedPrivateMethodRector #6509

Merged
merged 6 commits into from
Nov 25, 2024
Merged

[DeadCode] Skip private dataProvider method on RemoveUnusedPrivateMethodRector #6509

merged 6 commits into from
Nov 25, 2024
+108 −1

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @umpirsky

@samsonasik samsonasik changed the title [DeadCode] Skip dataProvider method on RemoveUnusedPrivateMethodRector [DeadCode] Skip private dataProvider method on RemoveUnusedPrivateMethodRector Nov 25, 2024
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 12b4710 into main Nov 25, 2024
36 checks passed
@samsonasik samsonasik deleted the skip-data-prov branch November 25, 2024 14:20
@TomasVotruba
Copy link
Member

Thank you 👍

@umpirsky
Copy link

Thanks!

I guess this will be released in 1.2.11? Any idea when?

@TomasVotruba
Copy link
Member

TomasVotruba commented Nov 25, 2024 •
edited
Loading

This will be part of 2.0 upgrade, as we keep only single release line.

See rectorphp/rector#8815 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RemoveUnusedPrivateMethodRector removes PHPUnit data providers
4 participants
@samsonasik @TomasVotruba @umpirsky @actions-user