Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC: Separated regex matching in NodeNameResolver->isName() #4951

Merged
merged 4 commits into from
Sep 9, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 9, 2023

as discussed in #4950 (comment)


Afte todays patches rectorphp is running 100 seconds faster over the Mautic codebase.

latest stable release takes ~ 625.33s
rector@dev takes ~ 523s on my machine

.. and requires way less RAM

@samsonasik
Copy link
Member

@staabm please rebase to fix conflict, thank you.

@TomasVotruba
Copy link
Member

@staabm rector-symfony needs one last check, that name is not Expr. Then its ready to go 👍

@TomasVotruba
Copy link
Member

Thanks 👍

@staabm How are we doing on the performance numbers? :)

@TomasVotruba TomasVotruba merged commit 9a322af into rectorphp:main Sep 9, 2023
38 checks passed
@staabm staabm deleted the name-matching branch September 9, 2023 14:09
@staabm
Copy link
Contributor Author

staabm commented Sep 9, 2023

updated the PRs description above

@TomasVotruba
Copy link
Member

That's awesome improvement 👏 👏 👏

I wonder if we use regex by default somewhere else but actually don't need it 🤔

@samsonasik
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants