-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC: Separated regex matching in NodeNameResolver->isName() #4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Sep 9, 2023
staabm
commented
Sep 9, 2023
rules/Transform/Rector/Class_/AddAllowDynamicPropertiesAttributeRector.php
Show resolved
Hide resolved
TomasVotruba
reviewed
Sep 9, 2023
@staabm please rebase to fix conflict, thank you. |
@staabm rector-symfony needs one last check, that name is not |
staabm
force-pushed
the
name-matching
branch
from
September 9, 2023 14:03
a983e69
to
b252c54
Compare
Thanks 👍 @staabm How are we doing on the performance numbers? :) |
updated the PRs description above |
That's awesome improvement 👏 👏 👏 I wonder if we use regex by default somewhere else but actually don't need it 🤔 |
@staabm it seems cause error on rector-phpunit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #4950 (comment)
Afte todays patches rectorphp is running 100 seconds faster over the Mautic codebase.
latest stable release takes ~ 625.33s
rector@dev takes ~ 523s on my machine
.. and requires way less RAM