Skip to content

Fix interface implementer in AddOverrideAttributeToOverriddenMethodsRector, add override only in case of overiding parent method with contents #12718

Fix interface implementer in AddOverrideAttributeToOverriddenMethodsRector, add override only in case of overiding parent method with contents

Fix interface implementer in AddOverrideAttributeToOverriddenMethodsRector, add override only in case of overiding parent method with contents #12718

Workflow file for this run

# This workflow runs system tests: Use the Rector application from the source
# checkout to process "fixture" projects in e2e/ directory
# to see if those can be processed successfully
name: End to End tests with cache
on:
pull_request:
branches:
- main
push:
branches:
- main
env:
# see https://github.com/composer/composer/issues/9368#issuecomment-718112361
COMPOSER_ROOT_VERSION: "dev-main"
jobs:
end_to_end:
runs-on: ubuntu-latest
timeout-minutes: 3
strategy:
fail-fast: false
matrix:
php_version: ['8.2']
directory:
- 'e2e/applied-rule-removed-node-with-cache'
- 'e2e/timeout-file-not-cached'
name: End to end test - ${{ matrix.directory }}
steps:
- uses: actions/checkout@v4
- uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php_version }}
coverage: none
# run in root rector-src
- run: composer install --ansi
# run in e2e subdir
-
run: composer install --ansi
working-directory: ${{ matrix.directory }}
# run e2e test
- run: php ../e2eTestRunner.php
working-directory: ${{ matrix.directory }}
# this tests that a 2nd run with cache and "--dry-run" gives same results, see https://github.com/rectorphp/rector-src/pull/3614#issuecomment-1507742338
- run: php ../e2eTestRunnerWithCache.php
working-directory: ${{ matrix.directory }}