Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQuality] Skip used by trait and multiple props on NarrowUnusedSetUpDefinedPropertyRector #400

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik samsonasik changed the title [CodeQuality] Skip used by trait on NarrowUnusedSetUpDefinedPropertyRector [CodeQuality] Skip used by trait and multiple props on NarrowUnusedSetUpDefinedPropertyRector Nov 5, 2024
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit e54d4ad into main Nov 5, 2024
6 checks passed
@samsonasik samsonasik deleted the skip-used-by-trait branch November 5, 2024 15:36
@TomasVotruba
Copy link
Member

Looks good 👍

What project have you tested it on to get these fails? :D

@samsonasik
Copy link
Member Author

CodeIgniter 4, the usage is something like: use DatabaseTrait for fixture filling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants