Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Implement dynamic command-groups #380

Closed
wants to merge 4 commits into from
Closed

[SYCL][Graph] Implement dynamic command-groups #380

wants to merge 4 commits into from

Commits on Oct 31, 2024

  1. [SYCL][Graph] Implement dynamic command-groups 

    Implement Dynamic Command-Group feature specified in
PR [[SYCL][Graph] Add specification for kernel binary updates](intel#14896)

This feature enables updating `ur_kernel_handle_t` objects in graph nodes
between executions as well as parameters and execution range of nodes.

This functionality is currently supported on CUDA & HIP which are used
for testing in the new E2E tests. Level Zero support will follow
shortly, resulting in the removal of the `XFAIL` labels from the E2E
tests.

The code for adding nodes to a graph has been refactored to split out
verification of edges, and marking memory objects used in a node, as
separate helper functions. This allows path for adding a command-group
node to do this functions over each CG in the list before creating the
node itself.

The `dynamic_parameter_impl` code has also been refactored so the code
is shared for updating a dynamic parameter used in both a regular kernel
node and a dynamic command-group node.

See the addition to the design doc for further details on the
implementation.
    @EwanC
    EwanC committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5d184e9 View commit details
    Browse the repository at this point in the history

  2. Refactor scheduler code 

    Create helper function for getting UR details out of CG.
    @EwanC
    EwanC committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e78f249 View commit details
    Browse the repository at this point in the history

  3. Reintroduce unittest for range update errors

    @EwanC
    EwanC committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    89193f0 View commit details
    Browse the repository at this point in the history

  4. Refactor raw arg update

    @EwanC
    EwanC committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3737c98 View commit details
    Browse the repository at this point in the history