Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Add API for updating single node parameters #340

Closed
wants to merge 23 commits into from
Closed

[SYCL][Graph] Add API for updating single node parameters #340

wants to merge 23 commits into from

Commits on Dec 12, 2023

  1. [SYCL][Graph] Add APIs for updating single node parameters 

    - New API and wording for updating single parameters
- Add some queries to node and modifiable graphs to support more mixed use cases
- Add deleted constructor to node which was missing
    @Bensuo @EwanC
    Bensuo authored and EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    0c7012d View commit details
    Browse the repository at this point in the history

  2. Expand node_type enum

    @Bensuo @EwanC
    Bensuo authored and EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c9a8b77 View commit details
    Browse the repository at this point in the history

  3. Detail compatible parameters in function defintion

    @Bensuo @EwanC
    Bensuo authored and EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    0e9b321 View commit details
    Browse the repository at this point in the history

  4. Add wording about dynamic params not changing graph structure

    @Bensuo @EwanC
    Bensuo authored and EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a93290c View commit details
    Browse the repository at this point in the history

  5. Fix typos and add new queries

    @Bensuo @EwanC
    Bensuo authored and EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    f3408b0 View commit details
    Browse the repository at this point in the history

  6. Minor superficial tweaks

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    9859ac1 View commit details
    Browse the repository at this point in the history

  7. Give dynamic_parameter its own constructor

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6046db0 View commit details
    Browse the repository at this point in the history

  8. Add finalization property to allow a graph to be updated.

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    fd65441 View commit details
    Browse the repository at this point in the history

  9. Address PR comments

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e0f882d View commit details
    Browse the repository at this point in the history

  10. Remove nodes list from update_dynamic_parameter()

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    52448a5 View commit details
    Browse the repository at this point in the history

  11. Enable update by argument index.

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    adc0a4d View commit details
    Browse the repository at this point in the history

  12. Template dynamic parameter type

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    4419ea9 View commit details
    Browse the repository at this point in the history

  13. Clarifications 

    Clarify that it's buffer accessors, not a `sycl::buffer` that
are used for registration and update of buffer-type dynamic
parameters.

Other clarifications based on PR feedback.
    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    83f8852 View commit details
    Browse the repository at this point in the history

  14. Change semantics of dyn param retaining values

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    89e8a24 View commit details
    Browse the repository at this point in the history

  15. Make registration and update methods on the dynamic_parameter

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    9c62653 View commit details
    Browse the repository at this point in the history

  16. Minor cleanup

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5d4c8a4 View commit details
    Browse the repository at this point in the history

  17. updatable must be set for nd-range update

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    35f81f0 View commit details
    Browse the repository at this point in the history

  18. Add raw dynamic parameter type

    @EwanC
    EwanC committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    47ce7bf View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Expand on multiple registration

    @EwanC
    EwanC committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c324d0a View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Remove scalar/raw registration by matching

    @EwanC
    EwanC committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    360fa1b View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Rename query functions to get predecessors/successors

    @EwanC
    EwanC committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    358412c View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Remove queries from this PR

    @Bensuo
    Bensuo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6406b2a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Merge branch 'sycl' into ben/explicit-update

    @reble
    reble committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    d98b8db View commit details
    Browse the repository at this point in the history