[SYCL][Graph] Add exceptions on using spec constants, kernel bundles and reductions #290
Conversation
Bensuo
commented
Aug 7, 2023
•
Bensuo
commented
- Add exceptions when using spec constants, kernel bundles and reductions
- Unit tests for spec constants and kernel bundles.
- Refactored handler throwing code to remove templates.
- Moved and renamed unsupported features enum to graph header.
- Add exceptions when using spec constants and kernel bundles - Unit tests for both of these. - Refactored handler throwing code to remove templates. - Moved and renamed unsupported features enum to graph header.
Bensuo
added
Graph Implementation
Yup, this branch does fix the linking error on Windows |
- Add exceptions on reduction use - Updated reduction tests to be XFAIL - Tweak exception message wording
…reble/llvm into ben/spec-const-bundle-exception
Bensuo
changed the title
|
@EwanC I've also pushed changes adding exceptions for Reductions here to make use of the refactored error handling code. Tagging for re-review, sorry! |
There was a problem hiding this comment.
In a previous PR, I changed the parametrized throwIfGraphAssociated function into a template function to be in line with other throw functions used by handle (as suggest by @reble in his comment #276 (comment) ).
I understand that changing back the template function into a parametrized function fixes the Windows compilation issue, but we should be aware that less consistent with the other throw functions of this file (and it also may impact performances as it makes the inlining of this function less intuitive for the compiler?)
- Also updates Linux ABI symbols
I've changed this back to a template but kept the definition in the header to avoid the template specializations 👍 |
…and reductions (#290) - Add exceptions when using spec constants, reductions and kernel bundles - Unit tests added for these. - Refactored handler throwing code to remove templates specializations. - Moved and renamed unsupported features enum to graph header. - Updated reduction tests to be XFAIL - Tweak exception message wording - Update ABI symbol tests. --------- Co-authored-by: Ewan Crawford <[email protected]>
