Feet(profiles): update textviews (#221)

* nothing * feet: Attached strings * feet(fix) --------- Co-authored-by: rebel onion <[email protected]>
rebelonion · Mar 7, 2024 · 95fa5dc · 95fa5dc
1 parent a2ca163
commit 95fa5dc
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 26 deletions.
diff --git a/app/src/main/res/layout/activity_profile.xml b/app/src/main/res/layout/activity_profile.xml
@@ -101,7 +101,7 @@
                         android:backgroundTint="?attr/colorSecondaryContainer"
                         android:enabled="true"
                         android:fontFamily="@font/poppins_bold"
-                        android:text="Follow"
+                        android:text="@string/follow"
                         android:textColor="@color/bg_opp"
                         android:textSize="14sp"
                         app:cornerRadius="8dp"

diff --git a/app/src/main/res/layout/fragment_profile.xml b/app/src/main/res/layout/fragment_profile.xml
@@ -4,8 +4,7 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    android:orientation="vertical"
-    tools:ignore="HardcodedText">
+    android:orientation="vertical">
 
     <LinearLayout
         android:id="@+id/userListContainer"
@@ -145,8 +144,8 @@
             android:layout_marginTop="8dp"
             android:layout_marginEnd="32dp"
             android:fontFamily="@font/poppins_bold"
+            android:text="@string/stats"
             android:padding="8dp"
-            android:text="Stats"
             android:textSize="18sp"
             tools:ignore="HardcodedText" />
 
@@ -157,8 +156,7 @@
             android:paddingStart="32dp"
             android:paddingTop="16dp"
             android:paddingEnd="32dp"
-            android:paddingBottom="16dp"
-            tools:ignore="HardcodedText">
+            android:paddingBottom="16dp">
 
             <TableRow
                 android:layout_width="match_parent"
@@ -169,7 +167,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:alpha="0.58"
-                    android:text="Episodes watched"
+                    android:text="@string/episodes_watched"
                     android:textStyle="bold" />
 
                 <TextView
@@ -191,7 +189,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:alpha="0.58"
-                    android:text="Days watched"
+                    android:text="@string/days_watched"
                     android:textStyle="bold" />
 
                 <TextView
@@ -212,7 +210,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:alpha="0.58"
-                    android:text="Total Anime"
+                    android:text="@string/total_anime"
                     android:textStyle="bold" />
 
                 <TextView
@@ -233,7 +231,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:alpha="0.58"
-                    android:text="Anime Mean Score"
+                    android:text="@string/anime_mean_score"
                     android:textStyle="bold" />
 
                 <TextView
@@ -254,7 +252,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:alpha="0.58"
-                    android:text="Chapter read"
+                    android:text="@string/chapters_read"
                     android:textStyle="bold" />
 
                 <TextView
@@ -275,7 +273,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:alpha="0.58"
-                    android:text="Volume read"
+                    android:text="@string/volume_read"
                     android:textStyle="bold" />
 
                 <TextView
@@ -296,7 +294,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:alpha="0.58"
-                    android:text="Total Manga"
+                    android:text="@string/total_manga"
                     android:textStyle="bold" />
 
                 <TextView
@@ -317,7 +315,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:alpha="0.58"
-                    android:text="Manga Mean Score"
+                    android:text="@string/manga_mean_score"
                     android:textStyle="bold" />
 
                 <TextView
@@ -346,10 +344,10 @@
             android:layout_marginTop="8dp"
             android:layout_marginEnd="32dp"
             android:fontFamily="@font/poppins_bold"
+            android:text="@string/about_me"
             android:padding="8dp"
             android:text="Bio"
-            android:textSize="18sp"
-            tools:ignore="HardcodedText" />
+            android:textSize="18sp"/>
 
         <WebView
             android:id="@+id/profileUserBio"
@@ -467,8 +465,8 @@
             android:layout_marginTop="8dp"
             android:layout_marginEnd="32dp"
             android:fontFamily="@font/poppins_bold"
+            android:text="@string/fav_character"
             android:padding="8dp"
-            android:text="Favorite Characters"
             android:textSize="18sp" />
 
         <ani.dantotsu.FadingEdgeRecyclerView
@@ -500,8 +498,8 @@
             android:layout_marginTop="8dp"
             android:layout_marginEnd="32dp"
             android:fontFamily="@font/poppins_bold"
+            android:text="@string/fav_staff"
             android:padding="8dp"
-            android:text="Favorite Staff"
             android:textSize="18sp" />
 
         <ani.dantotsu.FadingEdgeRecyclerView

diff --git a/app/src/main/res/layout/item_follower.xml b/app/src/main/res/layout/item_follower.xml
@@ -57,10 +57,9 @@
             android:layout_height="wrap_content"
             android:layout_gravity="start|center_vertical"
             android:layout_marginStart="120dp"
-            android:text="Username"
+            android:text="@string/username"
             android:textColor="@color/bg_white"
             android:textSize="18sp"
-            android:textStyle="bold"
-            tools:ignore="HardcodedText" />
+            android:textStyle="bold"/>
     </com.google.android.material.card.MaterialCardView>
 </FrameLayout>
diff --git a/app/src/main/res/layout/item_follower_grid.xml b/app/src/main/res/layout/item_follower_grid.xml
@@ -27,11 +27,10 @@
         android:layout_height="wrap_content"
         android:layout_gravity="center_horizontal|center_vertical"
         android:fontFamily="@font/poppins_semi_bold"
-        android:text="Username"
+        android:text="@string/username"
         android:textColor="?attr/colorOnBackground"
         android:textSize="12sp"
         android:ellipsize="end"
-        android:textStyle="bold"
-        tools:ignore="HardcodedText" />
+        android:textStyle="bold"/>
 
 </LinearLayout>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -670,6 +670,19 @@
     <string name="view_following">View Following</string>
     <string name="menu">menu</string>
     <string name="view_followers">View Followers</string>
-
-
+    <string name="no_fav_anime">User has no favorite Anime</string>
+    <string name="no_fav_manga">User has no favorite Manga</string>
+    <string name="fav_character">Favourite Characters</string>
+    <string name="fav_staff">Favorite Staff</string>
+
+    <string name="stats">Stats</string>
+    <string name="days_watched">Days watched</string>
+    <string name="total_anime">Total Anime</string>
+    <string name="anime_mean_score">Anime Mean Score</string>
+    <string name="volume_read">Volume read</string>
+    <string name="total_manga">Total Manga</string>
+    <string name="manga_mean_score">Manga Mean Score</string>
+    <string name="about_me">About me</string>
+    <string name="follow">Follow</string>
+
 </resources>