Enable ref as valid prop #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
approved these changes
Nov 20, 2024
Comment on lines
+26
to
+27
| let button = getByRole("FancyButton", container); | ||
| expect(button->innerHTML)->toBe("Click me"); |
There was a problem hiding this comment.
Shouldn't we test here something about the ref? This test just shows that Button_with_ref is rendering ok.
There was a problem hiding this comment.
Sure, added another assertion but didn't want to go to clicks and other events to keep the test simple and fast
There was a problem hiding this comment.
Thanks. (I think the expect in line 27 can be removed, because it doesn't test anything related to the ref)
…esting-libraries
* '19' of github.com:/reasonml/reason-react:
Add deprecations on ReactDOMTestUtils
Add uri comment back on action
Update src/React.re
Update src/React.re
Update src/React.re
Snapshot with lower {}
…on-react into replace-testing-libraries * 'replace-testing-libraries' of github.com:/reasonml/reason-react: Bind React.act and React.actAsync
…on-react into ref-as-valid-prop
* 'replace-testing-libraries' of github.com:/reasonml/reason-react:
Bind React.act and React.actAsync
Bind React.act and React.actAsync
Add deprecations on ReactDOMTestUtils
Add uri comment back on action
Add comment on install --force
Remove jest from demo/dune
Update src/React.re
Update src/React.re
Update src/React.re
Snapshot with lower {}
…lid-prop * '19' of github.com:/reasonml/reason-react: Replace react dom's testing library with ReactTestingLibrary (#859)
davesnx
force-pushed
the
ref-as-valid-prop
branch
from
2d60883 to
15e0877
Compare
davesnx
added a commit
that referenced
this pull request
Nov 25, 2024
…ises-as-annotations * '19' of github.com:/reasonml/reason-react: Enable ref as valid prop (#862) Replace react dom's testing library with ReactTestingLibrary (#859) Add deprecations on ReactDOMTestUtils Add uri comment back on action Update src/React.re Update src/React.re Update src/React.re Snapshot with lower {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #859, that depends on #846
Allows to have a prop with
~refThis PR also adds the cleanup function on
refas a new constructor: added another "constructor" instead of changing the current callbackRef to avoid a breaking change, we might add deprecations and further cleanup in the future versions to keep those constructors to the minimum