Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc/in-app-purchases-example #5

Merged
merged 41 commits into from
Nov 22, 2023
Merged

Conversation

marcabreracast
Copy link
Collaborator

No description provided.

Copy link
Contributor

@dianaafanador3 dianaafanador3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work here, just some minor comments. Also, will love for some more detailed (step by step) explanation of the store kit integration and the purchase verification, meaning, more comments on the code and an step by step explanation of this in the README.

marcabreracast and others added 24 commits November 7, 2023 14:55
…s/RealmManager.swift

Co-authored-by: Diana Perez Afanador <[email protected]>
…s/StoreKitManager.swift


Correct typo

Co-authored-by: Diana Perez Afanador <[email protected]>
…swift-samples into mc/in_app_purchases_example
Copy link
Contributor

@dianaafanador3 dianaafanador3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!. Excellent work with this example, just some minor comments before merging

InAppPurchasesAtlasAppServices/README.md Outdated Show resolved Hide resolved

This example contains a skeleton app to be used as a reference on how to In App Purchase with a seamless integration in App Services using the [Swift SDK](https://www.mongodb.com/docs/realm/sdk/swift/#realm-swift-sdk).
In this project you will be able to see an example of the following use case:
* Authenticate users using the Swift SDK.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing some point explaining with integrate with store kit and what we do with it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it now with more details. Let me know if it's better or if you want more detailed information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, I thinks that's all the comments solved

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for all the help and the review! I'll go ahead and squash and merge

@marcabreracast marcabreracast merged commit 69bab75 into main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants