Added viewIsAppearing in viewLifecycleMethodNames (#5316)

realm · Nov 1, 2023 · 6dc4b86 · 6dc4b86
1 parent 48604d3
commit 6dc4b86
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,6 +40,10 @@
 * Rewrite `duplicate_imports` rule using SwiftSyntax.  
   [JP Simard](https://github.com/jpsim)
 
+* Handle `viewIsAppearing` in the `type_contents_order` rule.  
+  [u-abyss](https://github.com/u-abyss)
+  [#5259](https://github.com/realm/SwiftLint/issues/5259)
+
 #### Bug Fixes
 
 * Fix correction of `explicit_init` rule by keeping significant trivia.  

diff --git a/Source/SwiftLintBuiltInRules/Rules/Style/TypeContentsOrderRule.swift b/Source/SwiftLintBuiltInRules/Rules/Style/TypeContentsOrderRule.swift
@@ -110,6 +110,7 @@ struct TypeContentsOrderRule: OptInRule {
             let viewLifecycleMethodNames = [
                 "loadView(",
                 "loadViewIfNeeded(",
+                "viewIsAppearing(",
                 "viewDidLoad(",
                 "viewWillAppear(",
                 "viewWillLayoutSubviews(",

diff --git a/Source/SwiftLintBuiltInRules/Rules/Style/TypeContentsOrderRuleExamples.swift b/Source/SwiftLintBuiltInRules/Rules/Style/TypeContentsOrderRuleExamples.swift
@@ -78,6 +78,10 @@ internal struct TypeContentsOrderRuleExamples {
                 view2.layoutIfNeeded()
                 hasLayoutedView2 = true
             }
+
+            override func viewIsAppearing(_ animated: Bool) {
+                super.viewIsAppearing(animated)
+            }
         """,
         """
             // IBActions