This repository has been archived by the owner on Jul 9, 2022. It is now read-only.
forked from google/closure-compiler
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move standardized document methods to w3c_dom1.js and remove useless …
…overrides of same methods by HTMLDocument The open(...), close(), write(...) and writeln(...) methods on Document are now part of the standard and have been moved to w3c_dom1.js to reflect this. The typing of Document.prototype.open and Document.prototype.close was previously incomplete. These have been aligned with the specification and with the methods in HTMLDocument that overrode these methods. This may impact type checking but that would be very surprising. The overrides in HTMLDocument have been removed. This is done due to limitations of the jsinterop-generator tool that is more fully described in google/jsinterop-generator#35 While the specifications explicitly indicate that these overrides are present and annotates (requiring the [OverrideBuiltins] attribute be applied to the containing interface in WebIDL) it is not expected that this has any practical impact on programs type checking against the externs.
- Loading branch information
1 parent
bd445e7
commit b8fef4e
Showing
3 changed files
with
28 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters