Update Editor menus #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Reality Toolkit
FejZa
previously approved these changes
Feb 17, 2024
There was a problem hiding this comment.
I think this is okay for now but really it does not feel right hat the Utilities package adds a Reality Tooklit menu entry, since it is not related to the toolkit at all. Might make more sense to move the channel packer to Core. Though I have never used that utility to be fair. Not sure how much value it brings.
|
Agreed, we should move it to the toolkit, I'll update this PR just to remove it for now, which makes more sense |
Remove editor preferences static, as each package has their own root
FejZa
approved these changes
Feb 17, 2024
FejZa
added a commit
that referenced
this pull request
May 6, 2024
* Prep for release * Auto increment pre-release version to 1.0.1 [skip ci] * disable tagging for development upversion * Apply V2 workflows (#19) Co-authored-by: Simon Jackson <[email protected]> * Auto increment pre-release version to 1.0.1-pre-release.1 [skip ci] * Auto increment pre-release version to 1.0.2 [skip ci] * Fix prefab attribute does not render label (#21) * Auto increment pre-release version to 1.0.2-pre.1 [skip ci] * Auto increment pre-release version to 1.0.3 [skip ci] * Updated Rest features (#23) * Updating Rest utilities, added cancellation token to all calls. Plus clean up * Added Unit Tests to Rest functionality * Standardised overload options into a new RestArgs struct * Rationalised implementations for standards * Added overloaded Download function to return a byte[] or file string contents * Fix new script icon * Update workflow to multi-version for test * Updated PostForm following 2022 testing * Include uGUI dependency for the UI extensions in the package * Extract Canvas dependencies from the utility package * Final review and cleanup * Update Readme --------- Co-authored-by: Simon Jackson <[email protected]> * Auto increment pre-release version to 1.0.3-pre.1 [skip ci] * Auto increment pre-release version to 1.0.4 [skip ci] * Next release updates (#27) * Initial commit for next round of updates - Changed fixed use of verbs to use the constants from UnityWebRequest definition. - #26 Added additional exception handling to log instead of throw, returns a Failed response instead - #25 Added the ability to set global override parameters - Added the ability to set a preferred download location, either globally or per call. Default is Temp * Auto increment pre-release version to 1.0.4-pre.1 [skip ci] * Add CODEOWNERS * Update for 1.0.4 release (#29) * Auto increment pre-release version to 1.0.4-pre.2 [skip ci] * Address comments * Auto increment pre-release version to 1.0.5 [skip ci] * Added logging utilities for projects (#31) * Added logging utilities for projects * Address review comments * Auto increment pre-release version to 1.0.5-pre.1 [skip ci] * Extended the Unity File helper with an additional option to get all files and not just Unity's own files. (#32) Updated the GuidRegenerator to use all files as it should not be limited when working with a path. * Auto increment pre-release version to 1.0.5-pre.2 [skip ci] * Fix ambiguous call (#34) Co-authored-by: Dino Fejzagic <[email protected]> * Auto increment pre-release version to 1.0.5-pre.3 [skip ci] * Added a new Calculate Bounds extension and updated documentation for all (#35) * Auto increment pre-release version to 1.0.5-pre.4 [skip ci] * Update docs and readme for release (#36) * Auto increment pre-release version to 1.0.5-pre.5 [skip ci] * Auto increment pre-release version to 1.0.6 [skip ci] * Added audio streaming (#38) * Added audio streaming --------- Authored-by: Rony Portelli <[email protected]> * Auto increment pre-release version to 1.0.7 [skip ci] * Deprecate the Rest utilities as this is not providing value to the toolkit (#42) * Update readme, remove mention of rest * Remove Rest classes and folders * Clean up Rest Tests --------- Co-authored-by: Dino Fejzagić <[email protected]> * Auto increment pre-release version to 1.0.7-pre.1 [skip ci] * Auto increment pre-release version to 1.0.8 [skip ci] * Update Editor menus (#45) * Updating Channel packer tool to fit under the asset store version of the Reality Toolkit * Remove Channel package from Utilities * Remove editor preferences static, as each package has its own root * Auto increment pre-release version to 1.0.8-pre.1 [skip ci] * Remove warning and remove redundant type lookup (#46) * Auto increment pre-release version to 1.0.8-pre.2 [skip ci] * Auto increment pre-release version to 1.0.9 [skip ci] * Migrated all Service-Framework only components to the ServiceFramework (#50) * Auto increment pre-release version to 1.0.9-pre.1 [skip ci] * Auto increment pre-release version to 1.0.10 [skip ci] * Fix assembly info pre processor (#53) * Fix assembly info pre processor * Generate assembly infos * Auto increment pre-release version to 1.0.10-pre.1 [skip ci] * Backporting 2020 fix for recent update (#54) * Auto increment pre-release version to 1.0.10-pre.2 [skip ci] --------- Co-authored-by: realitycollectivebuildbot <[email protected]> Co-authored-by: Simon Jackson <[email protected]> Co-authored-by: Dino Fejzagić <[email protected]> Co-authored-by: Dino Fejzagic <[email protected]> Co-authored-by: Rony Portelli <[email protected]>
FejZa
added a commit
that referenced
this pull request
May 6, 2024
* Prep for release * Auto increment pre-release version to 1.0.1 [skip ci] * disable tagging for development upversion * Apply V2 workflows (#19) Co-authored-by: Simon Jackson <[email protected]> * Auto increment pre-release version to 1.0.1-pre-release.1 [skip ci] * Auto increment pre-release version to 1.0.2 [skip ci] * Fix prefab attribute does not render label (#21) * Auto increment pre-release version to 1.0.2-pre.1 [skip ci] * Auto increment pre-release version to 1.0.3 [skip ci] * Updated Rest features (#23) * Updating Rest utilities, added cancellation token to all calls. Plus clean up * Added Unit Tests to Rest functionality * Standardised overload options into a new RestArgs struct * Rationalised implementations for standards * Added overloaded Download function to return a byte[] or file string contents * Fix new script icon * Update workflow to multi-version for test * Updated PostForm following 2022 testing * Include uGUI dependency for the UI extensions in the package * Extract Canvas dependencies from the utility package * Final review and cleanup * Update Readme --------- Co-authored-by: Simon Jackson <[email protected]> * Auto increment pre-release version to 1.0.3-pre.1 [skip ci] * Auto increment pre-release version to 1.0.4 [skip ci] * Next release updates (#27) * Initial commit for next round of updates - Changed fixed use of verbs to use the constants from UnityWebRequest definition. - #26 Added additional exception handling to log instead of throw, returns a Failed response instead - #25 Added the ability to set global override parameters - Added the ability to set a preferred download location, either globally or per call. Default is Temp * Auto increment pre-release version to 1.0.4-pre.1 [skip ci] * Add CODEOWNERS * Update for 1.0.4 release (#29) * Auto increment pre-release version to 1.0.4-pre.2 [skip ci] * Address comments * Auto increment pre-release version to 1.0.5 [skip ci] * Added logging utilities for projects (#31) * Added logging utilities for projects * Address review comments * Auto increment pre-release version to 1.0.5-pre.1 [skip ci] * Extended the Unity File helper with an additional option to get all files and not just Unity's own files. (#32) Updated the GuidRegenerator to use all files as it should not be limited when working with a path. * Auto increment pre-release version to 1.0.5-pre.2 [skip ci] * Fix ambiguous call (#34) Co-authored-by: Dino Fejzagic <[email protected]> * Auto increment pre-release version to 1.0.5-pre.3 [skip ci] * Added a new Calculate Bounds extension and updated documentation for all (#35) * Auto increment pre-release version to 1.0.5-pre.4 [skip ci] * Update docs and readme for release (#36) * Auto increment pre-release version to 1.0.5-pre.5 [skip ci] * Auto increment pre-release version to 1.0.6 [skip ci] * Added audio streaming (#38) * Added audio streaming --------- Authored-by: Rony Portelli <[email protected]> * Auto increment pre-release version to 1.0.7 [skip ci] * Deprecate the Rest utilities as this is not providing value to the toolkit (#42) * Update readme, remove mention of rest * Remove Rest classes and folders * Clean up Rest Tests --------- Co-authored-by: Dino Fejzagić <[email protected]> * Auto increment pre-release version to 1.0.7-pre.1 [skip ci] * Auto increment pre-release version to 1.0.8 [skip ci] * Update Editor menus (#45) * Updating Channel packer tool to fit under the asset store version of the Reality Toolkit * Remove Channel package from Utilities * Remove editor preferences static, as each package has its own root * Auto increment pre-release version to 1.0.8-pre.1 [skip ci] * Remove warning and remove redundant type lookup (#46) * Auto increment pre-release version to 1.0.8-pre.2 [skip ci] * Auto increment pre-release version to 1.0.9 [skip ci] * Migrated all Service-Framework only components to the ServiceFramework (#50) * Auto increment pre-release version to 1.0.9-pre.1 [skip ci] * Auto increment pre-release version to 1.0.10 [skip ci] * Fix assembly info pre processor (#53) * Fix assembly info pre processor * Generate assembly infos * Auto increment pre-release version to 1.0.10-pre.1 [skip ci] * Backporting 2020 fix for recent update (#54) * Auto increment pre-release version to 1.0.10-pre.2 [skip ci] * Auto increment pre-release version to 1.0.11 [skip ci] * Feature/ImprovedBoundsExtension (#55) * Migrated new functionality for bounds, needs sanitising * Modified the bounds extension to achieve the correct behaviour --------- Co-authored-by: Rony Portelli <[email protected]> * Auto increment pre-release version to 1.0.11-pre.1 [skip ci] * Cleaned up utilities package, removed duplicates between SF and Utilities/Toolkit (#56) * Update package json with missing fields * Clear icons and fix extensions and attributes namespace * Progress * Finish * Auto increment pre-release version to 1.0.11-pre.2 [skip ci] * Migrate @Cangi s work on the MatrixExtensions (#57) Co-authored-by: Dino Fejzagić <[email protected]> * Auto increment pre-release version to 1.0.11-pre.3 [skip ci] * Added new TryGet component search methods (#59) * Added new TryGet component search methods * Address feedback * Update readme with latest contents and banner * Auto increment pre-release version to 1.0.11-pre.4 [skip ci] --------- Co-authored-by: Simon (Darkside) Jackson <[email protected]> Co-authored-by: realitycollectivebuildbot <[email protected]> Co-authored-by: Simon Jackson <[email protected]> Co-authored-by: Dino Fejzagic <[email protected]> Co-authored-by: Rony Portelli <[email protected]> Co-authored-by: Rony Portelli <[email protected]>
FejZa
added a commit
that referenced
this pull request
May 6, 2024
* Prep for release * Auto increment pre-release version to 1.0.1 [skip ci] * disable tagging for development upversion * Apply V2 workflows (#19) Co-authored-by: Simon Jackson <[email protected]> * Auto increment pre-release version to 1.0.1-pre-release.1 [skip ci] * Auto increment pre-release version to 1.0.2 [skip ci] * Fix prefab attribute does not render label (#21) * Auto increment pre-release version to 1.0.2-pre.1 [skip ci] * Auto increment pre-release version to 1.0.3 [skip ci] * Updated Rest features (#23) * Updating Rest utilities, added cancellation token to all calls. Plus clean up * Added Unit Tests to Rest functionality * Standardised overload options into a new RestArgs struct * Rationalised implementations for standards * Added overloaded Download function to return a byte[] or file string contents * Fix new script icon * Update workflow to multi-version for test * Updated PostForm following 2022 testing * Include uGUI dependency for the UI extensions in the package * Extract Canvas dependencies from the utility package * Final review and cleanup * Update Readme --------- Co-authored-by: Simon Jackson <[email protected]> * Auto increment pre-release version to 1.0.3-pre.1 [skip ci] * Auto increment pre-release version to 1.0.4 [skip ci] * Next release updates (#27) * Initial commit for next round of updates - Changed fixed use of verbs to use the constants from UnityWebRequest definition. - #26 Added additional exception handling to log instead of throw, returns a Failed response instead - #25 Added the ability to set global override parameters - Added the ability to set a preferred download location, either globally or per call. Default is Temp * Auto increment pre-release version to 1.0.4-pre.1 [skip ci] * Add CODEOWNERS * Update for 1.0.4 release (#29) * Auto increment pre-release version to 1.0.4-pre.2 [skip ci] * Address comments * Auto increment pre-release version to 1.0.5 [skip ci] * Added logging utilities for projects (#31) * Added logging utilities for projects * Address review comments * Auto increment pre-release version to 1.0.5-pre.1 [skip ci] * Extended the Unity File helper with an additional option to get all files and not just Unity's own files. (#32) Updated the GuidRegenerator to use all files as it should not be limited when working with a path. * Auto increment pre-release version to 1.0.5-pre.2 [skip ci] * Fix ambiguous call (#34) Co-authored-by: Dino Fejzagic <[email protected]> * Auto increment pre-release version to 1.0.5-pre.3 [skip ci] * Added a new Calculate Bounds extension and updated documentation for all (#35) * Auto increment pre-release version to 1.0.5-pre.4 [skip ci] * Update docs and readme for release (#36) * Auto increment pre-release version to 1.0.5-pre.5 [skip ci] * Auto increment pre-release version to 1.0.6 [skip ci] * Added audio streaming (#38) * Added audio streaming --------- Authored-by: Rony Portelli <[email protected]> * Auto increment pre-release version to 1.0.7 [skip ci] * Deprecate the Rest utilities as this is not providing value to the toolkit (#42) * Update readme, remove mention of rest * Remove Rest classes and folders * Clean up Rest Tests --------- Co-authored-by: Dino Fejzagić <[email protected]> * Auto increment pre-release version to 1.0.7-pre.1 [skip ci] * Auto increment pre-release version to 1.0.8 [skip ci] * Update Editor menus (#45) * Updating Channel packer tool to fit under the asset store version of the Reality Toolkit * Remove Channel package from Utilities * Remove editor preferences static, as each package has its own root * Auto increment pre-release version to 1.0.8-pre.1 [skip ci] * Remove warning and remove redundant type lookup (#46) * Auto increment pre-release version to 1.0.8-pre.2 [skip ci] * Auto increment pre-release version to 1.0.9 [skip ci] * Migrated all Service-Framework only components to the ServiceFramework (#50) * Auto increment pre-release version to 1.0.9-pre.1 [skip ci] * Auto increment pre-release version to 1.0.10 [skip ci] * Fix assembly info pre processor (#53) * Fix assembly info pre processor * Generate assembly infos * Auto increment pre-release version to 1.0.10-pre.1 [skip ci] * Backporting 2020 fix for recent update (#54) * Auto increment pre-release version to 1.0.10-pre.2 [skip ci] * Auto increment pre-release version to 1.0.11 [skip ci] * Feature/ImprovedBoundsExtension (#55) * Migrated new functionality for bounds, needs sanitising * Modified the bounds extension to achieve the correct behaviour --------- Co-authored-by: Rony Portelli <[email protected]> * Auto increment pre-release version to 1.0.11-pre.1 [skip ci] * Cleaned up utilities package, removed duplicates between SF and Utilities/Toolkit (#56) * Update package json with missing fields * Clear icons and fix extensions and attributes namespace * Progress * Finish * Auto increment pre-release version to 1.0.11-pre.2 [skip ci] * Migrate @Cangi s work on the MatrixExtensions (#57) Co-authored-by: Dino Fejzagić <[email protected]> * Auto increment pre-release version to 1.0.11-pre.3 [skip ci] * Added new TryGet component search methods (#59) * Added new TryGet component search methods * Address feedback * Update readme with latest contents and banner * Auto increment pre-release version to 1.0.11-pre.4 [skip ci] * Auto increment pre-release version to 1.0.12 [skip ci] * Resolve merge issues (#60) * Auto increment pre-release version to 1.0.12-pre.1 [skip ci] --------- Co-authored-by: Simon (Darkside) Jackson <[email protected]> Co-authored-by: realitycollectivebuildbot <[email protected]> Co-authored-by: Simon Jackson <[email protected]> Co-authored-by: Dino Fejzagic <[email protected]> Co-authored-by: Rony Portelli <[email protected]> Co-authored-by: Rony Portelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reality Collective - Utilities Pull Request
Overview
Updating the Channel packer tool to fit under the asset store version of the Reality Toolkit