Enable searching for inherited services #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reality Collective - Service Framework Pull Request
Overview
In cases where you want a generic search for services implemented with a base interface, this change enables this capability, e.g.
Base Interface : IApplicationSettings
Generic Interface : IMyApplicationSettings : IApplication Settings.
Now the service is searchable by either its base interface "IMyApplicationSettings" or its inherited interface "IApplicationSettings".
Warning, if there are multiple services registered with the same inherited interface, ONLY the first registered instance would be found. To get all services returned with the inherited interface, then "GetAllServices" should be used.
Changes
Breaking Changes
Testing status
Breaking change
Should implementations expect a failure where inherited services look for a single service, these will now return the first service with the inherited interface.