railtie: Fix connection pools #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `readyset.connection_pool` railtie was setting up the connection pool for the gem by calling `ConnectionHandler.establish_connection`, which was resulting in the connection pool's database key being set to that of the primary database instead of "readyset". This commit resolves the issue by relying directly on `ActiveRecord::Base.establish_connection` to set up the connection pool. It also adds unit test converage to ensure the connection pool is set up as expected.
Merged
helpotters
reviewed
Jan 25, 2024
| pools = ActiveRecord::Base.connection_handler.connection_pools | ||
| readyset_pool = pools.find { |pool| pool.shard == Readyset.config.shard } | ||
|
|
||
| expect(readyset_pool).not_to be_nil |
There was a problem hiding this comment.
question: Is the nil expectation here just in-case the bottom two expectations turn up nil? 👀
There was a problem hiding this comment.
I just wanted to make explicit that a connection pool for Readyset should exist at that point
helpotters
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
readyset.connection_poolrailtie was setting up the connection pool for the gem by callingConnectionHandler.establish_connection, which was resulting in the connection pool's database key being set to that of the primary database instead of "readyset". This commit resolves the issue by relying directly onActiveRecord::Base.establish_connectionto set up the connection pool. It also adds unit test converage to ensure the connection pool is set up as expected.