-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Rake tasks for interactivity [feature] #60
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking for a general review of what I have so far! |
ethowitz
force-pushed
the
feature-rake-tasks
branch
from
January 19, 2024 20:02
44d0a78
to
64e0de2
Compare
@helpotters I used what you did as a starting point and expanded upon it to add a few more tasks I think will be useful. I also reworked the specs to run against the live postgres/readyset instances that are running in CI now |
ethan-readyset
requested review from
ethan-readyset and
jasobrown-rs
and removed request for
ethan-readyset
January 19, 2024 20:08
- cache_supported_queries => Readyset::Query.cache_all_supported! - drop_all_caches => Readyset::Query.drop_all_caches! - all_caches => Readyset::Query.all_cached
ethowitz
force-pushed
the
feature-rake-tasks
branch
from
January 22, 2024 21:11
0aa47b0
to
2cc6949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readyset::Query.cache_all_supported!
Readyset::Query.drop_all_caches!
Readyset::Query.all_cached
Still need to add a progress bar for
cache_supported_queries