Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add article to the FALLBACK_DOCTOOL list #448

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add article to the FALLBACK_DOCTOOL list #448

merged 1 commit into from
Nov 25, 2024

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 22, 2024

It seems this is common enough in other doc tools,
I think we should probably include it in the default?

I hit this with markdoc, where main includes the sidebars and other non-primary content.

It seems this is commmon enough in other doc tools,
I think we should probably include it in the default?
@ericholscher ericholscher marked this pull request as ready for review November 22, 2024 17:00
@ericholscher ericholscher requested review from humitos and a team as code owners November 22, 2024 17:00
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed. This seems to be an oversight from splitting up the selectors by tool, I think we already wanted this.

@humitos
Copy link
Member

humitos commented Nov 25, 2024

I hit this with markdoc, where main includes the sidebars and other non-primary content.

If we already know what's the correct selector for Markdoc, we should declare it on its own as well.

@humitos humitos merged commit 9140cc9 into main Nov 25, 2024
4 checks passed
@humitos humitos deleted the article branch November 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants