Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(temp): see if this action paradigm works #897

Closed
wants to merge 3 commits into from

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Sep 14, 2023

We currently build a single executable and publish a Docker image to the GitHub container registry, but now that we're using Rollup to build a single JS file, is it possible to use a JavaScript action instead? This PR is a little proof-of-concept of what that would look like.

For reference: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions

@kanadgupta
Copy link
Member Author

Update: this was stupidly easy to get working, but gonna close this out for now and revisit in the future. A few downsides:

  • it will require a few substantial changes to our release process (on top of everything else v9-related)
  • there are a few downsides (losing download count visibility, having to maintain a dist/ file, etc.)

@kanadgupta kanadgupta closed this Sep 14, 2023
@kanadgupta kanadgupta deleted the try-js-action branch September 14, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant