feat: adding support for node 18 (#495)

* feat: adding support for node 18 * test: fixing a broken test * chore: update comment Comment now reflects what the `engines.node` field looks like Co-authored-by: Kanad Gupta <[email protected]>
readmeio · Apr 20, 2022 · 774407d · 774407d
1 parent d331343
commit 774407d
Show file tree

Hide file tree

Showing 5 changed files with 265 additions and 300 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -8,7 +8,10 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 17.x]
+        node-version:
+          - 14
+          - 16
+          - 18
 
     steps:
       - uses: actions/checkout@v3

diff --git a/__tests__/lib/isSupportedNodeVersion.test.js b/__tests__/lib/isSupportedNodeVersion.test.js
@@ -4,11 +4,11 @@ describe('#isSupportedNodeVersion()', () => {
   it('should return true for a supported version of node', () => {
     expect(isSupportedNodeVersion('14.5.1')).toBe(true);
     expect(isSupportedNodeVersion('16.0.0')).toBe(true);
+    expect(isSupportedNodeVersion('18.0.0')).toBe(true);
   });
 
   it('should return false for an unsupported version of node', () => {
     expect(isSupportedNodeVersion('10.0.0')).toBe(false);
     expect(isSupportedNodeVersion('12.0.0')).toBe(false);
-    expect(isSupportedNodeVersion('18.0.0')).toBe(false);
   });
 });