chore(BREAKING): node 18 #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
requested review from
erunion,
domharrington,
mjcuva,
gratcliff and
jamestclark
kanadgupta
added
enhancement
erunion
approved these changes
Jan 8, 2024
gratcliff
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
BREAKING CHANGE: Bumps the minimum required Node versions for all of our Node packages.
By bumping to Node 18 (and therefore
npm@9), we can also bump our NPM lockfiles tolockfileVersion@3and remove a lot of duplicated lockfiles in the process.As part of this, our integration tests now
npm irather thannpm cisince there are no lockfiles in subdirectories for them to refer to. This is probably an improvement in a way since this more closely matches the dependency resolution approach our users would take.🧬 QA & Testing
Does everything still pass?