Merge branch 'main' into feat/dotnet-buffer-length

readmeio · Dec 10, 2024 · 8c73929 · 8c73929
2 parents ff74cd1 + 9514eef
commit 8c73929
Show file tree

Hide file tree

Showing 9 changed files with 127 additions and 190 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/dotnet/ReadMe/ConfigValues.cs b/packages/dotnet/ReadMe/ConfigValues.cs
@@ -27,5 +27,7 @@ public class Options
     public int bufferLength { get; set; } = 1;
 
     public string baseLogUrl { get; set; } = "https://example.readme.com";
+
+    public bool fireAndForget { get; set; } = true;
   }
 }
diff --git a/packages/dotnet/ReadMe/HarJsonTranslationLogics/ReadmeApiCaller.cs b/packages/dotnet/ReadMe/HarJsonTranslationLogics/ReadmeApiCaller.cs
@@ -16,7 +16,7 @@ public ReadMeApiCaller(string harJsonObjects, string apiKey)
       this.apiKey = apiKey;
     }
 
-    public void SendHarObjToReadMeApi()
+    public void SendHarObjToReadMeApi(bool fireAndForget)
     {
       try
       {
@@ -26,7 +26,14 @@ public void SendHarObjToReadMeApi()
         string apiKey = "Basic " + Convert.ToBase64String(Encoding.UTF8.GetBytes(this.apiKey + ":"));
         request.AddHeader("Authorization", apiKey);
         request.AddParameter("application/json", this.harJsonObjects, ParameterType.RequestBody);
-        client.ExecuteAsync(request);
+        if (fireAndForget)
+        {
+          client.ExecuteAsync(request);
+        }
+        else
+        {
+          client.Execute(request);
+        }
       }
       catch (Exception)
       {

diff --git a/packages/dotnet/ReadMe/Metrics.cs b/packages/dotnet/ReadMe/Metrics.cs
@@ -55,7 +55,7 @@ public async Task InvokeAsync(HttpContext context)
               {
                 string serializaedHars = JsonConvert.SerializeObject(this.harQueue);
                 ReadMeApiCaller readmeApiCaller = new ReadMeApiCaller(serializaedHars, configValues.apiKey);
-                readmeApiCaller.SendHarObjToReadMeApi();
+                readmeApiCaller.SendHarObjToReadMeApi(configValues.options.fireAndForget);
                 this.harQueue.Clear();
               }
             }
@@ -126,6 +126,11 @@ private ConfigValues GetConfigValues()
         optionsObj.baseLogUrl = options.GetSection("baseLogUrl").Value;
       }
 
+      if (options.GetSection("fireAndForget").Value != null)
+      {
+        optionsObj.fireAndForget = bool.Parse(options.GetSection("fireAndForget").Value);
+      }
+
       configValues.options = optionsObj;
       return configValues;
     }

diff --git a/packages/node/package.json b/packages/node/package.json
@@ -71,6 +71,6 @@
   "prettier": "@readme/eslint-config/prettier",
   "optionalDependencies": {
     "pino": "^9.3.2",
-    "pino-pretty": "^11.2.2"
+    "pino-pretty": "^13.0.0"
   }
 }