Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Changed
Link
andLocator
'shref
are normalized as valid URLs to improve interoperability with the Readium Web toolkits.Migration guide
Migration of HREFs and Locators (bookmarks, annotations, etc.)
Locator
objects.In Readium v2.x, a
Link
orLocator
'shref
could be either:https://domain.com/isbn/dir/my%20chapter.html
,/dir/my chapter.html
./
).To improve the interoperability with other Readium toolkits (in particular the Readium Web Toolkits, which only work in a streaming context) Readium v3 now generates and expects valid URLs for
Locator
andLink
'shref
.https://domain.com/isbn/dir/my%20chapter.html
is left unchanged, as it was already a valid URL./dir/my chapter.html
becomes the relative URL pathdir/my%20chapter.html
/
prefix to avoid issues when resolving to a base URL.You must migrate the HREFs or Locators stored in your database when upgrading to Readium 3. To assist you, two helpers are provided:
Url.fromLegacyHref()
andLocator.fromLegacyJSON()
.Here's an example of a Jetpack Room migration that can serve as inspiration: